Fix parameter ordering for Scrypt and Argon2 testcases #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
mikatammi
force-pushed
the
fix_pwdhashspec
branch
from
7e1c250 to
b2d477d
Compare
* Fix parameter ordering for Scrypt and Argon2 testcases * Change i, j, k to more descriptive names of the parameters * Add comments where to find the parameter orders from Botan's C++ code Signed-off-by: Mika Tammi <mikatammi@gmail.com>
mikatammi
force-pushed
the
fix_pwdhashspec
branch
from
ed73deb to
b34c51c
Compare
Contributor
Author
|
I have questions based on the comments that already exist in the PwdHashSpec.hs:
|
Collaborator
|
Thank you for the PR! I might need a little more time to get familiar with the code myself to review your changes and to answer your questsions, but the fixes are most appreciated. |
Collaborator
|
I included your changes in PR #63. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some investigation from Botan sources to really check how things work. pwdhash function seems to take arguments in a different order than what pwdHashTimed returns, when using Argon2 and Scrypt KDFs.
Also changed the names i, j, k to more descriptive ones: iterations, parallelism, memoryParam
There is open issue about this open since 2019:
randombit/botan#2144